Skip to content

Navigation Menu

Sign in
Sign up

Remove unused UIManager binding from React private interface (#58399) - #58399

Closed
rubennorte wants to merge 4 commits into
react:main from
rubennorte:export-D119166138
Closed

Remove unused UIManager binding from React private interface (#58399) #58399
rubennorte wants to merge 4 commits into
react:main from
rubennorte:export-D119166138

Conversation

@rubennorte

@rubennorte rubennorte commented Sep 8, 2026
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown
Member

Summary:

After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.

Changelog: [internal]

Reviewed By: cortinico

Differential Revision: D119166138

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2026

meta-codesync Bot commented Sep 8, 2026

Copy link
Copy Markdown

@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119166138.

rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 8, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Differential Revision: D119166138
@meta-codesync meta-codesync Bot changed the title (削除) Remove unused UIManager binding from React private interface (削除ここまで) (追記) Remove unused UIManager binding from React private interface (#58399) (追記ここまで) Sep 10, 2026
rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 10, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Differential Revision: D119166138
rubennorte force-pushed the export-D119166138 branch 2 times, most recently from 534aee1 to 11f733c Compare September 10, 2026 13:31
rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 10, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Differential Revision: D119166138

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 10, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Reviewed By: cortinico
Differential Revision: D119166138
rubennorte force-pushed the export-D119166138 branch 2 times, most recently from b5c20b9 to edd4ee7 Compare September 10, 2026 14:23
rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 10, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Reviewed By: cortinico
Differential Revision: D119166138
rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 10, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Reviewed By: cortinico
Differential Revision: D119166138
rubennorte added a commit to rubennorte/react-native that referenced this pull request Sep 10, 2026
...8399)
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Reviewed By: cortinico
Differential Revision: D119166138
rubennorte and others added 4 commits September 10, 2026 08:38
Summary:
Remove the isOSS conditionals that were skipping Fantom renderer tests in OSS environments. Now that the React Native renderers have been upgraded and the code is compatible in OSS, these tests can run in both internal and OSS environments.
Changes:
- ResponderEventTarget-itest.js: Removed isOSS check that skipped the entire Responder System test suite
- EventTargetDispatching-itest.js: Removed isOSS check that skipped the entire EventTarget-based Event Dispatching test suite
- EventDispatching-benchmark-itest.js: Removed if (isOSS) block that provided a dummy test instead of the benchmark suite
- EventDispatching-itest.js: Removed if (!isOSS) condition guarding three tests for native event timeStamp and global event dispatching
Changelog: [Internal]
Differential Revision: D107675643
Summary:
The renderer can dispatch events either through the legacy plugin-based system or through the W3C EventTarget API (addEventListener/dispatchEvent), gated behind the enableNativeEventTargetEventDispatching feature flag. Enabling it by default was previously blocked on the renderer, which did not carry the necessary changes until React 19.3.0. That sync has now landed, so flip the flag's default value to true and drop the TODO that tracked the blocker.
Fully removing the flag and the legacy dispatch path is left for a follow-up.
Changelog:
[General][Changed] - Dispatch events through the EventTarget API by default
Differential Revision: D119495069
...8399)
Summary:
Pull Request resolved: react#58399
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Reviewed By: cortinico
Differential Revision: D119166138

meta-codesync Bot commented Sep 11, 2026

Copy link
Copy Markdown

This pull request has been merged in 625df0c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /