-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Remove unused UIManager binding from React private interface (#58399) - #58399
Closed
rubennorte wants to merge 4 commits into
Closed
Remove unused UIManager binding from React private interface (#58399) #58399rubennorte wants to merge 4 commits into
rubennorte wants to merge 4 commits into
Conversation
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 8, 2026
@facebook-github-tools
facebook-github-tools
Bot
added
p: Facebook
Partner: Facebook
Partner
labels
Sep 8, 2026
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119166138.
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Differential Revision: D119166138
@meta-codesync
meta-codesync
Bot
changed the title
(削除) Remove unused UIManager binding from React private interface (削除ここまで)
(追記) Remove unused UIManager binding from React private interface (#58399) (追記ここまで)
Sep 10, 2026
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Differential Revision: D119166138
rubennorte
force-pushed
the
export-D119166138
branch
2 times, most recently
from
September 10, 2026 13:31
534aee1 to
11f733c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Differential Revision: D119166138
cortinico
cortinico
approved these changes
Sep 10, 2026
@cortinico
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Reviewed By: cortinico Differential Revision: D119166138
rubennorte
force-pushed
the
export-D119166138
branch
2 times, most recently
from
September 10, 2026 14:23
b5c20b9 to
edd4ee7
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Reviewed By: cortinico Differential Revision: D119166138
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Reviewed By: cortinico Differential Revision: D119166138
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
...8399) Summary: After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Reviewed By: cortinico Differential Revision: D119166138
rubennorte
force-pushed
the
export-D119166138
branch
from
September 10, 2026 15:14
edd4ee7 to
4b50815
Compare
Differential Revision: D119490598
Summary: Remove the isOSS conditionals that were skipping Fantom renderer tests in OSS environments. Now that the React Native renderers have been upgraded and the code is compatible in OSS, these tests can run in both internal and OSS environments. Changes: - ResponderEventTarget-itest.js: Removed isOSS check that skipped the entire Responder System test suite - EventTargetDispatching-itest.js: Removed isOSS check that skipped the entire EventTarget-based Event Dispatching test suite - EventDispatching-benchmark-itest.js: Removed if (isOSS) block that provided a dummy test instead of the benchmark suite - EventDispatching-itest.js: Removed if (!isOSS) condition guarding three tests for native event timeStamp and global event dispatching Changelog: [Internal] Differential Revision: D107675643
Summary: The renderer can dispatch events either through the legacy plugin-based system or through the W3C EventTarget API (addEventListener/dispatchEvent), gated behind the enableNativeEventTargetEventDispatching feature flag. Enabling it by default was previously blocked on the renderer, which did not carry the necessary changes until React 19.3.0. That sync has now landed, so flip the flag's default value to true and drop the TODO that tracked the blocker. Fully removing the flag and the legacy dispatch path is left for a follow-up. Changelog: [General][Changed] - Dispatch events through the EventTarget API by default Differential Revision: D119495069
...8399) Summary: Pull Request resolved: react#58399 After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface. Changelog: [internal] Reviewed By: cortinico Differential Revision: D119166138
rubennorte
force-pushed
the
export-D119166138
branch
from
September 10, 2026 15:45
4b50815 to
089ba46
Compare
This pull request has been merged in 625df0c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary:
After Paper was cleaned up from React in react/react#36285 this property is no longer used in React and can be removed from the interface.
Changelog: [internal]
Reviewed By: cortinico
Differential Revision: D119166138